| Index
» Projects
» phpMyEdit
» Bug list
» Bug #216 |
 |
|
Viewing Bug Advanced Details |
[ Jump to Bugnotes ]
[ Bug History ]
[ Print ]
|
|
ID |
Category |
Severity |
Reproducibility |
Date Submitted |
Last Update |
|
0000216 |
core / general |
feature |
always |
2004-04-09 12:38 |
2004-05-20 14:27 |
|
|
|
Reporter |
michal |
View Status |
public |
|
|
Assigned To |
|
|
Priority |
normal |
Resolution |
open |
Platform |
|
|
Status |
feedback |
Duplicate ID |
|
OS |
|
|
Projection |
none |
|
Version |
|
|
ETA |
none |
|
Product Version |
current from CVS |
|
|
Product Build |
130 |
|
|
Votes |
1 |
|
|
|
Summary |
hidden variables |
|
Description |
currently, hidden variables (such as page number, filters, sorting, persist, ...) are defined at 3 diferent places. This makes it possible to return to exactly the same place after hiting cancel button.
|
|
Steps To Reproduce |
|
|
Additional Information / Solution |
attached patch defines function return_hidden_vars which returns all hidden variables necessary. other two auxiliary functions create input hidden elements or href strings for use in parts of pme. |
|
Attached Files |
hidden.vars.130.diff (9,389 bytes) 2004-04-09 12:38
hidden.vars-v2.130.diff (12,212 bytes) 2004-04-10 10:50
hidden.vars-v4.130.diff (14,426 bytes) 2004-04-27 12:42
hidden.vars-v5.130.diff (14,984 bytes) 2004-05-20 14:24 |
|
|
|
Bug Notes |
michal
2004-04-09 16:42
|
this is connected to http://platon.sk/forum/projects/viewtopic.php?t=249 |
|
|
michal
2004-04-10 10:55
|
a new v2 patch against 130 cvs uploaded. some code cleanup and optimalizations.
after closely studing pme code, new return_hidden_variables now appears in 8 places :-). core class is now 2.3 kb less. |
|
|
nepto
2004-04-11 18:31
|
This is nice, however there are some problems:
1. SFN and similar string values are not decoded.
2. Pure '&' is used as URL variables separator in HTML code, while ' ' should be used.
3. Values and keys are not HTML escaped.
I will try to find time to fix this and apply into CVS. |
|
|
michal
2004-04-14 16:52
|
2, ok, line line patch (just href_hidden_vars)
3,1, i think this should be done in input_hidden_vars and href_hidden_vars. sometimes, the result is ran through htmlspecialchars(), sometimes not.
after some rethinking, href_hidden_vars and input_hidden_vars are not good names. these function have nothing to do with hidden_vars, but they just return hidden or href elements from any given array. just a cosmetic change. |
|
|
nepto
2004-04-14 17:10
|
Btw. why get_orig_vars() method is lost? It is very good method I think... It took some long time to have it working 100% properly. I think that already debuged and proven code should not be so easily discarded. |
|
|
michal
2004-04-27 12:46
|
new version uploaded. this one is really working, it produces the same output as cvs version. (most of the problem was applying htmlspecialchars twice :) )
get_orig_vars isn't lost just was divided into several other function... same with get_sfn. if you looked in the code of the new functions, you will see many similarities. but they are totally the same :)
so what do you think ? |
|
|
michal
2004-05-20 14:27
|
new version uploaded (5). the only difference is in moving of hidden variables in form_begin(). i believe it fits there a lot more. also some preparation for S mode is done, filters on non displayed columns are preserved. |
|
|
|
|
Login
Registration
Slovak
