phpMyEdit - Viewing Bug Advanced Details [ Go Back ]
527 core / general minor always 2008-04-30 17:08 2008-04-30 17:08
tsrwebmanager  
 
normal  
new 5.7.1 (stable)  
open  
none  
none  
Coding does not comply with standards
HTML produced fails to validate. There are
<input tags not closed,
<hr size="1" is only permitted under transitional standards,
<form name= is not permitted,
there are no <fieldset><fieldset> tags,
'disabled' in input is malformed
the name attribute in some input tags has no space before it.
Just validate output produced using W3C validator.
If one of the accredited owners contact me directly I will provide a temporary login to my members website where this is fixed/used]
Attached are the 2 fixed files, NOTE the line numbers below refer to these files, the only difference between these and your distribution is
a) the fixes
b) the removal of 26 commented out lines aroung line 1990
I have fixed these as follows (in both phpMyEdit.class and phpMyEdit-mce-cal.class).
Removed 'size="1"' attribute from all "<hr" tags and added "hr { height: 1px; }" into the css file [lines 373, 382, 1857, 1882, 1894, 1908, 1989, 2063, 3051]
the single occurrence of "<form" in phpMyEdit is now followed by <fieldset [line 970]
the 2 occurences (1 in each file) of "/form>" are now preceeded by /fieldset> [line 978 in myedit and line 483 in mce-cal]
the "name" attribute in the "<form" tag has been changed to "id" [line 970]
all occurences of "' disabled'" are replace by ' disabled="disabled"' [line 1048, 1079, 1196, 1225, 1249, 1479, 1594, mce-cal line 368, 399, 437]
the <input tag closures are changed from '>' to '/>' [line 1598, mce-cal line 405, 471]
"echo 'name" is changed to "echo ' name" [mce-cal line 470

There are no notes attached to this bug.